Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add title and other metadata #1151

Merged
merged 2 commits into from
Oct 31, 2024
Merged

chore: add title and other metadata #1151

merged 2 commits into from
Oct 31, 2024

Conversation

Shurtu-gal
Copy link
Collaborator

Description

Currently title just shows the URL of the website which is not good.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 40e670a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Oct 26, 2024 •
edited
Loading

✅ Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit 40e670a
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/671d0fea946c5e00085ea023
😎 Deploy Preview https://deploy-preview-1151--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Oct 26, 2024 •
edited
Loading

✅ Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit 40e670a
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/671d0feab1f4ac00084d44ee
😎 Deploy Preview https://deploy-preview-1151--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Oct 26, 2024 •
edited
Loading

❌ Deploy Preview for studio-next failed.

Name Link
🔨 Latest commit 40e670a
🔍 Latest deploy log https://app.netlify.com/sites/studio-next/deploys/671d0fea8cd82e000806299d

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Shurtu-gal
Copy link
Collaborator Author

/ptal

@asyncapi-bot
Copy link
Contributor

@Amzani @magicmatatjahu @KhudaDad414 Please take a look at this PR. Thanks! 👋

@Shurtu-gal Shurtu-gal self-assigned this Oct 26, 2024
Amzani
Amzani approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@Amzani Amzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
As discussed in chat with @Shurtu-gal studio-next is failing as we still have Vercel config pointing to that dir, we can ignore it.
@fmvilas you could prolly remove that from Vercel
Thanks

@Shurtu-gal
Copy link
Collaborator Author

/rtm

@asyncapi-bot asyncapi-bot merged commit e332a8a into asyncapi:master Oct 31, 2024
19 of 23 checks passed
@Shurtu-gal Shurtu-gal deleted the chore/metadata branch October 31, 2024 11:33
@github-actions github-actions bot mentioned this pull request Nov 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amzani Amzani Amzani approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@KhudaDad414 KhudaDad414 Awaiting requested review from KhudaDad414 KhudaDad414 is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees

@Shurtu-gal Shurtu-gal

Labels
ready-to-merge
Projects
Studio - Kanban
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shurtu-gal @asyncapi-bot @Amzani